add log near err #3098
Merged
add log near err #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
add log
WHAT
🤖 Generated by Copilot at 6005137
This pull request improves the error handling and logging of various functions in the kube-ovn controller and daemon components. It adds log messages to report errors that occur when interacting with the informer cache, the ovn network, or the network resources. It also adds or modifies return statements to propagate errors to the callers. The purpose of these changes is to enhance the debugging and monitoring capabilities of the kube-ovn system. The affected files are
pkg/controller/*.goandcmd/daemon/cniserver.go.🤖 Generated by Copilot at 6005137
HOW
🤖 Generated by Copilot at 6005137
handleAddPodAnnotatedIptablesEipfunction inpkg/controller/pod_iptables_eip.goto use log message instead ofutilruntime.HandleErrorfunction (link)RemoveOldChassisInSbDBfunction inpkg/controller/ovn-ic.goto propagate errors when getting or deleting chassis records from ovn southbound database (link, link, link)syncExternalVpcfunction inpkg/controller/external_vpc.goto use error level and include error message when updating or deleting vpc fails (link, link)