Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ipam random get #3200

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix ipam random get #3200

merged 3 commits into from
Sep 12, 2023

Conversation

zbb88888
Copy link
Collaborator

@zbb88888 zbb88888 commented Sep 11, 2023

What type of this PR

Examples of user facing changes:

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at b78654a

Improve IP allocation performance and debuggability for pods. Add logging of pod name and IP range in subnet.go. Simplify free IP list update logic.

🤖 Generated by Copilot at b78654a

The pods need some IPs to run
But the allocation was not fun
So subnet.go got a tweak
With logging and logic more sleek
Now the performance is second to none

HOW

🤖 Generated by Copilot at b78654a

  • Add logging statements to the functions that allocate random IP addresses for pods from subnets, for debugging purposes (link, link)
  • Optimize the logic of updating the free IP list after allocating an IP address for a pod, by avoiding unnecessary splitting and appending of the IP range (link, link)

Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
@zbb88888
Copy link
Collaborator Author

hi @oilbeater , could you help review?

Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
@zbb88888 zbb88888 merged commit 0eb4f79 into kubeovn:release-1.11 Sep 12, 2023
@zbb88888 zbb88888 deleted the fix-ipam-random branch September 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants