Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: remove subnet finalizers before subnets are deleted #3213

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Sep 14, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

#3169

WHAT

🤖 Generated by Copilot at 712199e

This pull request improves the GitHub Actions workflow, the OVS and OVN upgrade process, and the Kube-OVN chart uninstallation. It renames some jobs and containers, adds a cleanup step, a pre-delete hook, and a new make target. It affects the files .github/workflows/build-x86-image.yaml, charts/templates/upgrade-ovs-ovn.yaml, charts/templates/pre-delete-hook.yaml, and Makefile.

🤖 Generated by Copilot at 712199e

We unleash the hook of doom
To purge the finalizers from the subnets
We test the chart with helm and make
To ensure the Kube-OVN image is flawless

HOW

🤖 Generated by Copilot at 712199e

  • Rename the chart installation test job to chart-test for consistency and clarity (link)
  • Add a step to uninstall the Kube-OVN chart after testing it to clean up resources (link, link)
  • Add a pre-delete hook to the Kube-OVN chart to remove finalizers from subnets before deleting the chart, to avoid subnets being stuck in terminating state (link)
  • Rename the post-upgrade job and container to {{ .Chart.Name }}-post-upgrade-hook and ovs-ovn-upgrade respectively, to be more descriptive and avoid conflicts (link, link)

Signed-off-by: 张祖建 <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian added bug Something isn't working need backport chart Helm Chart labels Sep 14, 2023
@zhangzujian zhangzujian changed the title chart: remove subnet finalizer before uninstallation chart: remove subnet finalizers before subnets are deleted Sep 14, 2023
Signed-off-by: 张祖建 <zhangzujian.7@gmail.com>
Signed-off-by: 张祖建 <zhangzujian.7@gmail.com>
@zhangzujian zhangzujian marked this pull request as ready for review September 14, 2023 02:35
@zhangzujian zhangzujian merged commit eb74761 into kubeovn:master Sep 14, 2023
@zhangzujian zhangzujian deleted the fix-chart-uninstall branch September 14, 2023 02:49
zhangzujian added a commit to zhangzujian/kube-ovn that referenced this pull request Sep 14, 2023
)

Signed-off-by: 张祖建 <zhangzujian.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart Helm Chart need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants