Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust vip prints as ip #3248

Merged
merged 1 commit into from
Sep 25, 2023
Merged

adjust vip prints as ip #3248

merged 1 commit into from
Sep 25, 2023

Conversation

zbb88888
Copy link
Collaborator

@zbb88888 zbb88888 commented Sep 22, 2023 •
edited by ghost
Loading

What type of this PR

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at ea954e3

Removed NS column from Vlan CRD in yamls/crd.yaml to simplify kubectl get vlan output and avoid confusion with NAMESPACE column.

🤖 Generated by Copilot at ea954e3

NS column gone
kubectl get vlan clear
Autumn leaves confusion

HOW

🤖 Generated by Copilot at ea954e3

  • Remove the NS column from the Vlan CRD to simplify the output of kubectl get vlan and avoid confusion with the NAMESPACE column (link)

@zbb88888
Copy link
Collaborator Author

调整 vip 打印显示和 ip 打印显示的前几列保持一致

image

@zhangzujian
Copy link
Member

The helm chart should also be updated.

@zbb88888
adjust vip prints as ip
6b745f6 
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
@zbb88888
Copy link
Collaborator Author

The helm chart should also be updated.

updated

1 similar comment
@zbb88888
Copy link
Collaborator Author

The helm chart should also be updated.

updated

@zbb88888 zbb88888 merged commit 0ceb924 into kubeovn:master Sep 25, 2023
zbb88888 added a commit that referenced this pull request Sep 25, 2023
@zbb88888
adjust vip prints as ip (#3248)
e19b5b5 
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
@zbb88888 zbb88888 deleted the adjust-vip-print branch September 26, 2023 09:42
wenwenxiong pushed a commit to wenwenxiong/kube-ovn that referenced this pull request Sep 28, 2023
@zbb88888
adjust vip prints as ip (kubeovn#3248)
b6c4944 
Signed-off-by: bobz965 <zhangbingbing2_yewu@cmss.chinamobile.com>
Signed-off-by: xiongww <xiongww@chinatelecom.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oilbeater oilbeater oilbeater approved these changes

@hongzhen-ma hongzhen-ma Awaiting requested review from hongzhen-ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zbb88888 @zhangzujian @oilbeater