Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at f163dae
This pull request adds a feature flag to enable or disable the OVN database compaction in the OVN leader checker. The feature flag is exposed as an environment variable and a command line argument in the OVN leader checker code, and as a Helm value and an environment variable in the central pod templates for different deployment scenarios.
🤖 Generated by Copilot at f163dae
HOW
🤖 Generated by Copilot at f163dae
networking.ENABLE_COMPACT
to the default Helm values filecharts/values.yaml
with a default value offalse
(link)ENABLE_COMPACT
to the central pod template incharts/templates/central-deploy.yaml
and derive its value from the Helm values file (link)EnableCompact
to theConfiguration
type inpkg/ovn_leader_checker/ovn.go
to store the value of the environment variable (link)--enableCompact
to the OVN leader checker command line arguments inpkg/ovn_leader_checker/ovn.go
and parse the value of the environment variable (link)EnableCompact
field in the configuration inpkg/ovn_leader_checker/ovn.go
(link)EnableCompact
field in the configuration and only call thecompactOvnDatabase
function for the OVN northbound and southbound databases if the field istrue
in thedoOvnLeaderCheck
function inpkg/ovn_leader_checker/ovn.go
(link)ENABLE_COMPACT
environment variable tofalse
for the OVN-DPDK deployment inyamls/ovn-dpdk.yaml
(link)ENABLE_COMPACT
environment variable tofalse
for the OVN-HA deployment inyamls/ovn-ha.yaml
(link)