delete String() function #3488
Merged
delete String() function #3488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pengbinbin1 <pengbiny@163.com>
oilbeater
approved these changes
Dec 6, 2023
zbb88888
pushed a commit
that referenced
this pull request
Dec 6, 2023
Signed-off-by: pengbinbin1 <pengbiny@163.com>
zbb88888
pushed a commit
that referenced
this pull request
Dec 6, 2023
Signed-off-by: pengbinbin1 <pengbiny@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
In the net package,ip has implement the String() function,so we can print it directly with "%s"
Which issue(s) this PR fixes
Fixes #(issue-number)
WHAT
🤖[deprecated] Generated by Copilot at 6a0dd3a
Improved logging performance and readability in
ipam.go. Removed redundant string conversions of IP addresses in log messages.🤖[deprecated] Generated by Copilot at 6a0dd3a
HOW
🤖[deprecated] Generated by Copilot at 6a0dd3a
ip.String()calls from log messages inpkg/ipam/ipam.go(link, link, link, link)