Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The eip is not cleaned after eip is deleted (#4718) #4719

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

hackerain
Copy link
Contributor

The ip address in vpc-nat-gw pod is not cleaned after the eip is deleted. This patch fix this problem.

Pull Request

What type of this PR

Examples of user facing changes:

  • Features
  • Bug fixes
  • Docs
  • Tests

Which issue(s) this PR fixes

Fixes #(issue-number)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working vpc labels Nov 8, 2024
@oilbeater
Copy link
Collaborator

@hackerain the ut and DCO check failed.

The ip address in vpc-nat-gw pod is not cleaned after the eip
is deleted. This patch fix this problem.

Signed-off-by: Rain Suo <yugsuo@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@oilbeater oilbeater merged commit 92a0d95 into kubeovn:master Nov 12, 2024
64 checks passed
@oilbeater
Copy link
Collaborator

Thanks! @hackerain

oilbeater pushed a commit that referenced this pull request Nov 12, 2024
The ip address in vpc-nat-gw pod is not cleaned after the eip
is deleted. This patch fix this problem.

Signed-off-by: Rain Suo <yugsuo@gmail.com>
zbb88888 pushed a commit that referenced this pull request Dec 4, 2024
The ip address in vpc-nat-gw pod is not cleaned after the eip
is deleted. This patch fix this problem.

Signed-off-by: Rain Suo <yugsuo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. vpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants