cni: do not exit if the sysctl variable does not exist or can not be set #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
zhangzujian
force-pushed
the
fix-ipv6
branch
from
7894fc7 to
fcb6a45
Compare
Pull Request Test Coverage Report for Build 12308156494Details
💛 - Coveralls |
dosubot
bot
added
the
size:XS
oilbeater
approved these changes
Dec 13, 2024
zhangzujian
added a commit
that referenced
this pull request
Dec 13, 2024
…set (#4828) Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
|
@zhangzujian shouldn't we add a log entry too when error occurs? |
It's executed in the CNI plugin, not in kube-ovn-cni. Any logging will NOT passed to kubelet if the CNI command succeeds. We need a new mechanism to store the logging to a file on the host, or to pass it to kube-ovn-cni. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes
Fixes #(issue-number)