Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give admin owner role to all projects #6754

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Give admin owner role to all projects #6754

merged 1 commit into from
Aug 6, 2024

Conversation

ahmadhamzh
Copy link
Contributor

@ahmadhamzh ahmadhamzh commented Jul 30, 2024 •
edited by ahmedwaleedmalik
Loading

What this PR does / why we need it:
Grant admin all owner Privileges on all projects.

Which issue(s) this PR fixes:
Fixes #6753

What type of PR is this?
/kind bug
/kind feature

Grant admin all owner Privileges on all projects.

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2024
@ahmadhamzh ahmadhamzh added this to the KKP 2.26 milestone Jul 30, 2024
@ahmadhamzh ahmadhamzh removed this from the KKP 2.26 milestone Aug 6, 2024
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. and removed docs/none Denotes a PR that doesn't need documentation (changes). labels Aug 6, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a34bf67c435dcf18fa39ffab1d626b1c5844ca58

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@ahmedwaleedmalik ahmedwaleedmalik added needs-release-testing Denotes a PR or issue that needs to be tested before release. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2024
@ahmedwaleedmalik
Copy link
Member

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
@kubermatic-bot kubermatic-bot merged commit a1c8fb5 into kubermatic:main Aug 6, 2024
8 checks passed
@kubermatic-bot kubermatic-bot added this to the KKP 2.26 milestone Aug 6, 2024
@ahmedwaleedmalik ahmedwaleedmalik removed the needs-release-testing Denotes a PR or issue that needs to be tested before release. label Sep 11, 2024
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Sep 27, 2024
@judge-red judge-red mentioned this pull request Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api Denotes a PR or issue as being assigned to SIG API. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KKP 2.26
Development

Successfully merging this pull request may close these issues.

KKP Admin not able to manage RBAC assignment and Project assignment
3 participants
@ahmadhamzh @kubermatic-bot @ahmedwaleedmalik