Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Feature Stages page in Main, 2.25 and 2.26 #1768

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Create Feature Stages page in Main, 2.25 and 2.26 #1768

wants to merge 9 commits into from

Conversation

csengerszabo
Copy link
Contributor

Adding a Feature Stages page to the Kubermatic Documentation.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
xmudrii
xmudrii approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for other folks to review (cc @xrstf @embik)

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 11, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec9c93f78567e10af0625776371f3006f6c32917

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2024
@xrstf
Copy link
Contributor

xrstf commented Oct 11, 2024

So this does not apply to KKP 2.26?

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2024
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 11, 2024
@csengerszabo
Copy link
Contributor Author

So this does not apply to KKP 2.26?

@xrstf good point, I added it now.

@csengerszabo csengerszabo changed the title Create Feature Stages page in Main and 2.25 Create Feature Stages page in Main, 2.25 and 2.26 Oct 11, 2024
@csengerszabo
Copy link
Contributor Author

@xmudrii @xrstf can you take a second look and approve if all good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii Awaiting requested review from xmudrii

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@csengerszabo @kubermatic-bot @xrstf @xmudrii