Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeone containerd migration #712

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 8, 2021

Accompaniment docs for kubermatic/kubeone#1362

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Jun 8, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Jun 8, 2021

/hold

until kubermatic/kubeone#1362 is merged

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2021
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Jun 9, 2021

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@kron4eg kron4eg requested a review from mate4st June 9, 2021 12:26
@kron4eg
Copy link
Member Author

kron4eg commented Jun 9, 2021

/assign @weirdmachine

@mate4st
Copy link
Contributor

mate4st commented Jun 9, 2021

You might add this to kubeone v1.3 as well

@kron4eg
Copy link
Member Author

kron4eg commented Jun 9, 2021

@weirdmachine at the moment it’s pointless

@kron4eg
Copy link
Member Author

kron4eg commented Jun 9, 2021

I mean, when 1.3 will be "released" officially and then we will have docs, and will sync master to v1.3.

@mate4st
Copy link
Contributor

mate4st commented Jun 10, 2021

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 08c0d8ca04d2602376e29dd80d57534e52c357aa

@kubermatic-bot kubermatic-bot merged commit 1c528df into kubermatic:master Jun 10, 2021
@kron4eg kron4eg deleted the k1-containerd-migration branch June 10, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants