Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go modules #524

Closed
2 tasks done
xmudrii opened this issue Jul 1, 2019 · 3 comments · Fixed by #550
Closed
2 tasks done

Switch to Go modules #524

xmudrii opened this issue Jul 1, 2019 · 3 comments · Fixed by #550
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@xmudrii
Copy link
Member

xmudrii commented Jul 1, 2019

What feature would you like to be added?

With Go modules being more and more stable and becoming default soon, we should consider switching to Go modules. Kubernetes has also switched to Go modules as of 1.15.

AC

  • Switch to Go modules
  • Make code generation works after switching to Go modules

Resources

kubernetes/kubernetes#74877
Introduction to Go modules by Jordan Liggitt

@xmudrii xmudrii added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 1, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jul 1, 2019

@eqrx You may find this interesting as you already tried to make this work.

@kron4eg
Copy link
Member

kron4eg commented Jul 1, 2019

for generation we'd still need vendor (which we can easily get by running go mod vendor).

@xmudrii
Copy link
Member Author

xmudrii commented Jul 1, 2019

As an example implementation, you can see how cert-manager switched to Go modules.

@xmudrii xmudrii added this to the v0.10 milestone Jul 1, 2019
@eqrx eqrx mentioned this issue Jul 4, 2019
@eqrx eqrx added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/blocked Denotes an issue or PR is blocked. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/blocked Denotes an issue or PR is blocked. labels Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants