Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gomod #550

Merged
merged 4 commits into from
Jul 5, 2019
Merged

Gomod #550

merged 4 commits into from
Jul 5, 2019

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Jul 4, 2019

What this PR does / why we need it:
Makes KubeOne a go module

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #524

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

KubeOne is now a go module

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 4, 2019
kron4eg
kron4eg reviewed Jul 4, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

export GOPROXY=https://proxy.golang.org
export GO111MODULE=on

Is needed, plus:

  • a step with go mod vendor (for codegen)
  • go build -mod readonly

Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@eqrx eqrx force-pushed the gomod branch 3 times, most recently from 9fa3543 to 2aaa6fc Compare July 4, 2019 11:32
@eqrx eqrx added this to the v0.10 milestone Jul 4, 2019
@eqrx eqrx force-pushed the gomod branch 3 times, most recently from 99e6fa2 to 4c141ac Compare July 4, 2019 14:18
@eqrx eqrx self-assigned this Jul 4, 2019
@eqrx eqrx added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/blocked Denotes an issue or PR is blocked. labels Jul 4, 2019
@kubermatic-bot kubermatic-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
@eqrx eqrx added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/blocked Denotes an issue or PR is blocked. labels Jul 4, 2019
@kubermatic-bot kubermatic-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2019
@eqrx eqrx requested a review from kron4eg July 5, 2019 07:38
Alexander Sowitzki and others added 2 commits July 5, 2019 12:06
@kron4eg
Switch KubeOne to be a go module
d15e519 
Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
@kron4eg
Fix linter
7e812eb 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Add missing make dependency to linter
b2e2e6c 
Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
kron4eg
kron4eg approved these changes Jul 5, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3590c377d84ae9b31e662337fe5d6528e3e6c9fe

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 5, 2019
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@eqrx eqrx force-pushed the gomod branch 10 times, most recently from b5953ff to dd05c04 Compare July 5, 2019 14:49
Update run-ci-e2e-test.sh to run with modules
c556a86 
Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
@eqrx eqrx added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2019
@kubermatic-bot kubermatic-bot merged commit a9aa950 into master Jul 5, 2019
@kubermatic-bot kubermatic-bot deleted the gomod branch July 5, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

@eqrx eqrx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Switch to Go modules
3 participants
@eqrx @kubermatic-bot @kron4eg