Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the Canal MTU to 1450 when the v1alpha1 API is used and add the Canal MTU field to the example config #1016

Merged
merged 2 commits into from
Aug 4, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 4, 2020

What this PR does / why we need it:

  • Default the Canal MTU to 1450 when the v1alpha1 API is used. This fixes the issue preventing validation to pass when the v1alpha1 manifest is used
  • Add the Canal MTU field to the example config

Does this PR introduce a user-facing change?:

Default the Canal MTU to 1450 when the v1alpha1 API is used. This fixes the issue preventing validation to pass when the v1alpha1 manifest is used

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg August 4, 2020 15:20
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 4, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dfa0315d947f3679ec3697dd7213c2e9658973d

@xmudrii
Copy link
Member Author

xmudrii commented Aug 4, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Aug 4, 2020

/cherry-pick release/v1.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1018

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants