Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeone proxy command #1035

Merged
merged 2 commits into from
Aug 13, 2020
Merged

kubeone proxy command #1035

merged 2 commits into from
Aug 13, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 12, 2020

What this PR does / why we need it:
Launch local HTTPS capable proxy (CONNECT method) to tunnel HTTPS request via SSH. This is especially useful in cases when kubeapi endpoint is not accessible from the public internets.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #719

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

added: kubeone proxy command

Launch local HTTPS capable proxy (CONNECT method) to tunnel HTTPS
request via SSH

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii August 12, 2020 15:56
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 12, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2020
pkg/cmd/proxy.go Outdated Show resolved Hide resolved
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c40c0cb7b44ec6f44cfd5b9bd25e8c852672754c

@xmudrii
Copy link
Member

xmudrii commented Aug 13, 2020

/cherry-pick release/v1.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Aug 13, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit 89b29d5 into master Aug 13, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Aug 13, 2020
@kubermatic-bot kubermatic-bot deleted the proxy_cmd branch August 13, 2020 10:34
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1036

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kubeone tunnel proxy
3 participants