Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade machinecontroller to v1.16.1 #1043

Merged
merged 1 commit into from
Aug 15, 2020
Merged

Upgrade machinecontroller to v1.16.1 #1043

merged 1 commit into from
Aug 15, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 14, 2020 •
edited
Loading

What this PR does / why we need it:
To include fix for kubermatic/machine-controller#808

Which issue(s) this PR fixes:
xRef kubermatic/machine-controller#808

Does this PR introduce a user-facing change?:

Upgrade machinecontroller to v1.16.1

@kron4eg
Upgrade machinecontroller to v1.16.1
1aedc36 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii August 14, 2020 21:39
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Aug 14, 2020

/cherry-pick release/v1.0

@kubermatic-bot
Copy link
Contributor

@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v1.0 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Aug 15, 2020

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

@kron4eg: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xmudrii
xmudrii approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e6db4abf10e5b32f711fd3cbe3ade459bef32c4

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit eb85507 into master Aug 15, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Aug 15, 2020
@kubermatic-bot kubermatic-bot deleted the mc-1.16.1 branch August 15, 2020 13:44
@kubermatic-bot kubermatic-bot mentioned this pull request Aug 15, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@kron4eg: new pull request created: #1044

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii