Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudConfig to generated config examples #1062

Merged
merged 3 commits into from
Aug 22, 2020
Merged

Add cloudConfig to generated config examples #1062

merged 3 commits into from
Aug 22, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 21, 2020 

Include cloudConfig in generated config when it's required on validation

@kron4eg
Add cloudConfig to generated config examples
eee4b41 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii August 21, 2020 09:01
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 21, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 21, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Aug 21, 2020

/retest

xmudrii
xmudrii approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2020

Let's cherry-pick this to the release branch.

/cherry-pick release/v1.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.0 in a new PR and assign it to you.

In response to this:

Let's cherry-pick this to the release branch.

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xmudrii
xmudrii requested changes Aug 22, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

pkg/cmd/config.go Show resolved Hide resolved
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2020

@kron4eg Hope that you're not going to mind if I accept this suggestion. If you do, we can revert it, but I prefer that we keep the consistency between example and full configs.

@kubermatic-bot kubermatic-bot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2020
xmudrii
xmudrii approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm Indicates that a PR is ready to be merged. labels Aug 22, 2020
@xmudrii
Copy link
Member

xmudrii commented Aug 22, 2020

This doesn't work.

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
xmudrii
xmudrii reviewed Aug 22, 2020
View reviewed changes
pkg/cmd/config.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2020
xmudrii
xmudrii approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no new changes. All changes match what was in the original commit.

@kron4eg Sorry for playing around with commits. I wanted to see can I keep the consistency between configs, but that has failed.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15ff1384cdb0a5f6ecc4dba071fc55fcb6d770ef

@kubermatic-bot kubermatic-bot merged commit 1b52894 into master Aug 22, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Aug 22, 2020
@kubermatic-bot kubermatic-bot deleted the cloud-config-generated branch August 22, 2020 11:54
@kubermatic-bot kubermatic-bot mentioned this pull request Aug 22, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1065

In response to this:

Let's cherry-pick this to the release branch.

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii