Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machinecontroller to v1.17.2 #1105

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Update machinecontroller to v1.17.2 #1105

merged 2 commits into from
Sep 21, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 21, 2020

What this PR does / why we need it:
To include hetzner "image" field

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update machinecontroller to v1.17.2

@kron4eg
Update machinecontroller to v1.17.2
a7d312b 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 21, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2020

/test pull-kubeone-e2e-hetzner-conformance-1.19

@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2020

/hold

to be added terraform changes

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@kron4eg
Parse image from hetzner terraform output
734beb8 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
xmudrii
xmudrii approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c21446a930577cdeb8ab188c5ecab0faa485105d

@xmudrii
Copy link
Member

xmudrii commented Sep 21, 2020

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2020

/test pull-kubeone-e2e-hetzner-conformance-1.19

@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit c58b13b into master Sep 21, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Sep 21, 2020
@kubermatic-bot kubermatic-bot deleted the mc-v1.17.2 branch September 21, 2020 16:43
@xmudrii
Copy link
Member

xmudrii commented Sep 28, 2020

/cherry-pick release/v1.0

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 28, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1119

In response to this:

/cherry-pick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii