Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CentOS7 Docker repo for both CentOS 7 and 8 #1111

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Use CentOS7 Docker repo for both CentOS 7 and 8 #1111

merged 2 commits into from
Sep 24, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 24, 2020

What this PR does / why we need it:

CentOS has two different Docker repos for CentOS7 and CentOS8. The CentOS8 repo currently contains only Docker 19.03.13, which is not validated for all Kubernetes version. Therefore, we use the CentOS7 repo which has all Docker versions.

Does this PR introduce a user-facing change?:

Use CentOS7 Docker repo for both CentOS 7 and 8

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg September 24, 2020 10:19
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 24, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Sep 24, 2020

/hold
to manually test this
/cherrypick release/v1.0

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2020
@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.0 in a new PR and assign it to you.

In response to this:

/hold
to manually test this
/cherrypick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
kron4eg
kron4eg approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 71a296bd5dcb69b77ca3892098ed1f4034eeeb12

@xmudrii
Copy link
Member Author

xmudrii commented Sep 24, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Sep 24, 2020

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@ffuerste
Copy link
Contributor

Hi guys,

is there an ETA for this? Currently I am not able to create new kubernetes cluster on RHEL/CentOS 8, because of the updated upstream docker repo for CentOS (using $releasever now).

Is it possible to prioritize the issue accordingly?

@xmudrii
Copy link
Member Author

xmudrii commented Sep 24, 2020

@ffuerste This PR should fix the issue for the control plane nodes managed by KubeOne. There's also a PR to fix it for the machine-controller as well (kubermatic/machine-controller#826).

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
@kubermatic-bot kubermatic-bot merged commit 6636c39 into master Sep 24, 2020
@kubermatic-bot kubermatic-bot added this to the v1.1 milestone Sep 24, 2020
@kubermatic-bot kubermatic-bot deleted the centos-docker-version branch September 24, 2020 13:51
@kubermatic-bot kubermatic-bot mentioned this pull request Sep 24, 2020
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #1112

In response to this:

/hold
to manually test this
/cherrypick release/v1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii mentioned this pull request Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kubermatic-bot @ffuerste @kron4eg