Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the OverwriteRegistry functionality #1145

Merged
merged 7 commits into from
Oct 23, 2020
Merged

Implement the OverwriteRegistry functionality #1145

merged 7 commits into from
Oct 23, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 21, 2020

What this PR does / why we need it:

Implement the OverwriteRegistry functionality.

Does this PR introduce a user-facing change?:

Implement the OverwriteRegistry functionality

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg October 21, 2020 09:32
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 21, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Oct 23, 2020

/retest

@xmudrii xmudrii changed the title [WIP] Implement the OverwriteRegistry functionality Implement the OverwriteRegistry functionality Oct 23, 2020
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Oct 23, 2020

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Oct 23, 2020

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 340c473cdb9dba2068846ca5369d280c40ee47b8

@kubermatic-bot kubermatic-bot merged commit d45c010 into master Oct 23, 2020
@kubermatic-bot kubermatic-bot deleted the registry-override branch October 23, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg