Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hcloud-cloud-controller-manager image in hertzner.go #1149

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Update hcloud-cloud-controller-manager image in hertzner.go #1149

merged 1 commit into from
Nov 2, 2020

Conversation

cebor
Copy link
Contributor

@cebor cebor commented Oct 26, 2020 •
edited
Loading

What this PR does / why we need it:
Updates hcloud-cloud-controller-manager image in hertzner.go.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 26, 2020
@kubermatic-bot
Copy link
Contributor

Hi @cebor. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2020
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Oct 26, 2020
@kron4eg
Copy link
Member

kron4eg commented Oct 29, 2020

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2020
xmudrii
xmudrii requested changes Oct 29, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the reference here:

kubeone/hack/image-loader.sh

Line 113 in 56d768e

"docker.io/hetznercloud/hcloud-cloud-controller-manager:v1.7.0"

@kron4eg kron4eg removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 29, 2020
@cebor
Copy link
Contributor Author

cebor commented Oct 30, 2020

@xmudrii done.

Can we now use a reference in the template?

@kron4eg
Copy link
Member

kron4eg commented Oct 30, 2020

/ok-to-test
/lgtm

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Oct 30, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc75d71dc58ca68d4e9cfc8c6e5d204d834745e4

@kron4eg
Copy link
Member

kron4eg commented Oct 30, 2020

OK, while we didn't merged this the new release has arrived :) https://github.com/hetznercloud/hcloud-cloud-controller-manager/releases/tag/v1.8.1

@cebor
Copy link
Contributor Author

cebor commented Oct 30, 2020

Updated to 1.8.1

@xmudrii
Copy link
Member

xmudrii commented Oct 30, 2020

@cebor The diff still shows 1.18.0 for me, for some reason.

@cebor
Update hcloud-cloud-controller-manager image
f4ad49a 
Signed-off-by: Felix Itzenplitz <felix@stkn.org>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2020
@cebor
Copy link
Contributor Author

cebor commented Oct 30, 2020

Oops, forgot to add the files before committing.

@xmudrii
Copy link
Member

xmudrii commented Oct 30, 2020

/retest

xmudrii
xmudrii approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e20f747fcc3fedc16c8cf0bdb7aa24bcbcb2668e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cebor, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@kubermatic-bot kubermatic-bot merged commit 22ee7eb into kubermatic:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@kron4eg kron4eg

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cebor @kubermatic-bot @kron4eg @xmudrii