Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vSphere external CCM #1159

Merged
merged 4 commits into from
Nov 12, 2020

Conversation

maxilampert
Copy link
Contributor

What this PR does / why we need it:
Adds vShpere external ccm controller.
Example kubeone config used for testing. Tested with current version of vCenter and ESXi 7.

apiVersion: kubeone.io/v1beta1
kind: KubeOneCluster
versions:
  kubernetes: '1.19.3'
cloudProvider:
  vsphere: {}
  external: true
  cloudConfig: |+
    global:
      port: 443
      # set insecureFlag to true if the vCenter uses a self-signed cert
      insecureFlag: true
      # settings for using k8s secret
      secretName: vsphere-ccm-credentials
      secretNamespace: kube-system
    # vcenter section
    vcenter:
      tenant-example:
        server: vcsa.example.com
        datacenters:
          - DC

Which issue(s) this PR fixes:
Implements #616 for vSphere controller
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add vSphere external CCM

Signed-off-by: Maximilian Lampert <ml@mlampert.de>
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Nov 3, 2020
@kubermatic-bot
Copy link
Contributor

Hi @maxilampert. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2020
@kron4eg
Copy link
Member

kron4eg commented Nov 4, 2020

Thanks @maxilampert!

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2020
@kron4eg
Copy link
Member

kron4eg commented Nov 4, 2020

/test pull-kubeone-lint
/test pull-kubeone-test

Signed-off-by: Maximilian Lampert <ml@mlampert.de>
@kron4eg
Copy link
Member

kron4eg commented Nov 5, 2020

/retest

1 similar comment
@kron4eg
Copy link
Member

kron4eg commented Nov 5, 2020

/retest

@kron4eg
Copy link
Member

kron4eg commented Nov 5, 2020

/lgtm

@xmudrii PTAL

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8577d7b30ff01cc89b2c013ffd860073221a7efb

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some nits, but other than that, it looks very good.

pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
pkg/templates/externalccm/vsphere.go Outdated Show resolved Hide resolved
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgmt
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54a903d9f0941b58fca70698b68e82e9983e5dc0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, maxilampert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@kubermatic-bot kubermatic-bot merged commit fbd4516 into kubermatic:master Nov 12, 2020
@maxilampert maxilampert deleted the vsphere-ccm-external branch November 13, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants