-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vSphere external CCM #1159
Add vSphere external CCM #1159
Conversation
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
Hi @maxilampert. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @maxilampert! /ok-to-test |
/test pull-kubeone-lint |
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
/retest |
1 similar comment
/retest |
/lgtm @xmudrii PTAL |
LGTM label has been added. Git tree hash: 8577d7b30ff01cc89b2c013ffd860073221a7efb
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some nits, but other than that, it looks very good.
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgmt
/approve
LGTM label has been added. Git tree hash: 54a903d9f0941b58fca70698b68e82e9983e5dc0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg, maxilampert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds vShpere external ccm controller.
Example kubeone config used for testing. Tested with current version of vCenter and ESXi 7.
Which issue(s) this PR fixes:
Implements #616 for vSphere controller
Special notes for your reviewer:
Does this PR introduce a user-facing change?: