Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature machine deployment annotations #1174

Conversation

ffuerste
Copy link
Contributor

What this PR does / why we need it: It allows to define .meteadata.annotations for MachineDeployment resources in a KubeOne configuration file (.dynamicWorkers.providerSpec.annotations).
Among other possible use cases, it allows to define the cluster-autoscaler clusterapi annotations alongside other attributes for worker node groups in a KubeOne config file.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1133

Special notes for your reviewer:
The PR is based on the current kubeone master branch. The zz_generated.* files were created with the provided script hack/update-codegen.sh and verified with hack/verify-codegen.sh.

Does this PR introduce a user-facing change?:

No breaking changes are introduced with this PR.
User can optionally define annotations for `dynamicWorkers` elements in a KubeOne config file, which are used for the corresponding `MachineDeployment` resource.

Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
…n of machineDeployment object

Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2020
@kubermatic-bot
Copy link
Contributor

Hi @ffuerste. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 25, 2020
@xmudrii
Copy link
Member

xmudrii commented Nov 25, 2020

/test all

… v1alpha1 is frozen

Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
…notations field (which was not implemented to frozen v1alpha1 API)

Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
… v1alpha1 is frozen

Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
@ffuerste
Copy link
Contributor Author

/retest

@kubermatic-bot
Copy link
Contributor

@ffuerste: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Nov 25, 2020

/test all

@ffuerste
Copy link
Contributor Author

/retest

@kubermatic-bot
Copy link
Contributor

@ffuerste: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Nov 25, 2020

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a7bbd03bd349ca9621c08a18e754cbc9e09f9bf

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffuerste, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2020
@kubermatic-bot kubermatic-bot merged commit 90e1318 into kubermatic:master Nov 25, 2020
@ffuerste
Copy link
Contributor Author

Thanks for merging and the amazing fast replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow MachineDeployment annotations to be set via KubeOne
4 participants