-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature machine deployment annotations #1174
Feature machine deployment annotations #1174
Conversation
Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
…n of machineDeployment object Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
Hi @ffuerste. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
… v1alpha1 is frozen Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
…notations field (which was not implemented to frozen v1alpha1 API) Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
… v1alpha1 is frozen Signed-off-by: Florian Fürstenberg <florian.fuerstenberg@t-systems.com>
/retest |
@ffuerste: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/retest |
@ffuerste: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
LGTM label has been added. Git tree hash: 7a7bbd03bd349ca9621c08a18e754cbc9e09f9bf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ffuerste, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for merging and the amazing fast replies. |
What this PR does / why we need it: It allows to define
.meteadata.annotations
forMachineDeployment
resources in a KubeOne configuration file (.dynamicWorkers.providerSpec.annotations
).Among other possible use cases, it allows to define the cluster-autoscaler clusterapi annotations alongside other attributes for worker node groups in a KubeOne config file.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1133
Special notes for your reviewer:
The PR is based on the current kubeone master branch. The
zz_generated.*
files were created with the provided scripthack/update-codegen.sh
and verified withhack/verify-codegen.sh
.Does this PR introduce a user-facing change?: