Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual IP address for API server in vSphere example #1217

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

chrkl
Copy link

@chrkl chrkl commented Jan 18, 2021

Set up keepalived on control plane nodes in vSphere Terraform example to
establish virtual IP address for Kubernetes API. API endpoint in
Terraform output is set to first control plane node if no IP address is
specified. The existing Gobetween load-balancer is removed.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Replace GoBetween load-balancer in vSphere Terraform example by keepalived

Set up keepalived on control plane nodes in vSphere Terraform example to
establish virtual IP address for Kubernetes API. API endpoint in
Terraform output is set to first control plane node if no IP address is
specified. The existing Gobetween load-balancer is removed.
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 18, 2021
@chrkl
Copy link
Author

chrkl commented Jan 18, 2021

/assign @kron4eg

Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!! 🤩
/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6f5942de0a323473bc26c18b252bb5027a2af663

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrkl, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@kubermatic-bot kubermatic-bot merged commit 86fab08 into kubermatic:master Jan 18, 2021
@chrkl chrkl deleted the vsphere_keepalived branch January 18, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants