Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsync on CentOS and Amazon Linux #1240

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

chrkl
Copy link

@chrkl chrkl commented Feb 5, 2021

Rsync was installed on Ubuntu, but not CentOS and Amazon Linux

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
@chrkl
Copy link
Author

chrkl commented Feb 5, 2021

/assign @kron4eg

@xmudrii
Copy link
Member

xmudrii commented Feb 5, 2021

@chrkl Can you please update the test fixtures? You can do it by running go test ./... -update from the pkg directory.

@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 5, 2021
Rsync was installed on Ubuntu, but not CentOS and Amazon Linux
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: db1e0ff32585c846203199c2bfd5c96437659614

@kron4eg
Copy link
Member

kron4eg commented Feb 5, 2021

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrkl, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2021
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot merged commit 222201d into kubermatic:master Feb 5, 2021
@chrkl chrkl deleted the install_rsync branch February 5, 2021 11:15
hwuethrich added a commit to hwuethrich/kubeone that referenced this pull request Aug 3, 2021
* upstream/master: (21 commits)
  Improve the installation script (kubermatic#1253)
  Update README.md (kubermatic#1250)
  Add the changelog for the v1.2.0-beta.1 release (kubermatic#1249)
  Fix credentials in addons (kubermatic#1248)
  fix(docs): fix broken master documentation link (kubermatic#1246)
  Add encryption providers proposal (kubermatic#1213)
  Use Docker for restarting API server on Flatcar (kubermatic#1245)
  Add the Kubernetes 1.20 jobs (kubermatic#1244)
  Restart unhealthy API servers when provisioning/upgrading clusters (kubermatic#1243)
  Add rsync on CentOS and Amazon Linux (kubermatic#1240)
  Update machine-controller to v1.25.0 (kubermatic#1238)
  Update the kubeone-e2e image (kubermatic#1239)
  Update KubeOne CI jobs (kubermatic#1237)
  Disallow and deprecate the PodPresets feature (kubermatic#1236)
  Fix confusing default in OpenIDConnect (kubermatic#1235)
  Add debian support (kubermatic#1233)
  Drop mounting flexvolume plugins into the openstack CCM (kubermatic#1234)
  Remove CoreOS (kubermatic#1232)
  Add the changelog for the v1.2.0-beta.0 release (kubermatic#1230)
  Add containerRuntime API to the full config (kubermatic#1229)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants