Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support organizing addons into subdirectories #1364

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Support organizing addons into subdirectories #1364

merged 3 commits into from
Jun 3, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 3, 2021

What this PR does / why we need it:

  • Support organizing addons into subdirectories
    • Storing addons in the addons directory's root is still supported but is considered deprecated
    • We strongly recommend reorganizing your addons into subdirectories
  • Update unit tests to test the new behavior

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1363

Special notes for your reviewer:

/hold
to manually test the backward compatibility

Does this PR introduce a user-facing change?:

Support organizing addons into subdirectories
[DEPRECATED] Storing addons manifests in the addons directory's root is not recommended any longer and is considered deprecated. It currently remains possible to store addons in the addons directory's root, but this might be removed in the future KubeOne version. We strongly recommend reorganizing your addons into subdirectories.

/assign @kron4eg

@xmudrii
Support organizing addons into subdirectories
ef3090c 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update unit tests for addons
482441b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg June 3, 2021 10:41
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 3, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 3, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Jun 3, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
kron4eg
kron4eg reviewed Jun 3, 2021
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pkg/addons/addons.go Outdated Show resolved Hide resolved
@xmudrii
Fix review comments
e60f951 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Jun 3, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a8baa4a532ed5d6b6db0df8e4adb007e3013c5f1

@kubermatic-bot kubermatic-bot merged commit 6fa4ead into master Jun 3, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jun 3, 2021
@kubermatic-bot kubermatic-bot deleted the addons branch June 3, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.

Support organizing addons into subdirectories
3 participants
@xmudrii @kubermatic-bot @kron4eg