Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a mechanism for embedding YAML addons into KubeOne binary #1387

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 15, 2021

What this PR does / why we need it:

This PR implements a mechanism for embedding YAML addons into the KubeOne binary.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1351

Does this PR introduce a user-facing change?:

Implement a mechanism for embedding YAML addons into KubeOne binary

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg June 15, 2021 15:39
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 15, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021
@xmudrii
Copy link
Member Author

xmudrii commented Jun 15, 2021

/test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Jun 16, 2021

/test all

@xmudrii
Copy link
Member Author

xmudrii commented Jun 16, 2021

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Jun 16, 2021

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d475c4f9c349cc502e261628f50daed1e30c0786

@xmudrii xmudrii marked this pull request as ready for review June 16, 2021 08:58
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@kubermatic-bot kubermatic-bot merged commit da5f320 into master Jun 16, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jun 16, 2021
@kubermatic-bot kubermatic-bot deleted the embed-addons branch June 16, 2021 08:58
@kubermatic-bot
Copy link
Contributor

@xmudrii: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubeone-lint fcea437 link /test pull-kubeone-lint

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a mechanism for embedding YAML addons into KubeOne binary
3 participants