Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade machine-controller to v1.33.0 #1391

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Upgrade machine-controller to v1.33.0 #1391

merged 1 commit into from
Jun 30, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 16, 2021 •
edited
Loading

What this PR does / why we need it:
To fix some bugfixes since MC 1.30.x

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade machine-controller to v1.33.0

@kron4eg kron4eg requested a review from xmudrii June 16, 2021 10:50
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Jun 16, 2021

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Jun 16, 2021

/retest

xmudrii
xmudrii approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 285cad97c6bb1da15beadd49832e8ec60438f7d5

@kron4eg
Copy link
Member Author

kron4eg commented Jun 16, 2021

hmm...

@kron4eg
Copy link
Member Author

kron4eg commented Jun 16, 2021

/retest

1 similar comment
@kron4eg
Copy link
Member Author

kron4eg commented Jun 16, 2021

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg kron4eg marked this pull request as draft June 16, 2021 14:48
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@kron4eg kron4eg changed the title Upgrade machine-controller to v1.31.0 Upgrade machine-controller to v1.31.1 Jun 16, 2021
@kron4eg kron4eg marked this pull request as ready for review June 16, 2021 21:27
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@kron4eg kron4eg requested a review from xmudrii June 16, 2021 21:27
@kron4eg
Copy link
Member Author

kron4eg commented Jun 16, 2021

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Jun 17, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Jun 18, 2021

@xmudrii Seems like 1.18 doesn’t work with certificates v1 :(

@kron4eg kron4eg changed the title Upgrade machine-controller to v1.31.1 Upgrade machine-controller to v1.32.0 Jun 25, 2021
@kron4eg kron4eg marked this pull request as draft June 29, 2021 12:55
@kubermatic-bot
Copy link
Contributor

@kron4eg: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubermatic-kubeone-validate-prow-yaml
  • /test pull-kubeone-verify-boilerplate
  • /test pull-kubeone-verify-codegen
  • /test pull-kubeone-license-validation
  • /test pull-kubeone-build
  • /test pull-kubeone-test
  • /test pull-kubeone-lint
  • /test pull-kubeone-e2e-aws-containerd-conformance-1.18
  • /test pull-kubeone-e2e-aws-flatcar-containerd-conformance-1.18
  • /test pull-kubeone-e2e-aws-conformance-1.19
  • /test pull-kubeone-e2e-aws-conformance-1.20
  • /test pull-kubeone-e2e-aws-conformance-1.21
  • /test pull-kubeone-e2e-digitalocean-conformance-1.19
  • /test pull-kubeone-e2e-digitalocean-conformance-1.20
  • /test pull-kubeone-e2e-digitalocean-conformance-1.21
  • /test pull-kubeone-e2e-hetzner-conformance-1.19
  • /test pull-kubeone-e2e-hetzner-conformance-1.20
  • /test pull-kubeone-e2e-hetzner-conformance-1.21
  • /test pull-kubeone-e2e-gce-conformance-1.19
  • /test pull-kubeone-e2e-gce-conformance-1.20
  • /test pull-kubeone-e2e-gce-conformance-1.21
  • /test pull-kubeone-e2e-packet-conformance-1.19
  • /test pull-kubeone-e2e-packet-conformance-1.20
  • /test pull-kubeone-e2e-packet-conformance-1.21
  • /test pull-kubeone-e2e-openstack-conformance-1.19
  • /test pull-kubeone-e2e-openstack-conformance-1.20
  • /test pull-kubeone-e2e-openstack-conformance-1.21
  • /test pull-kubeone-e2e-aws-upgrade-containerd-1.17-1.18
  • /test pull-kubeone-e2e-aws-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-aws-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-aws-upgrade-1.20-1.21
  • /test pull-kubeone-e2e-digitalocean-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-digitalocean-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-digitalocean-upgrade-1.20-1.21
  • /test pull-kubeone-e2e-hetzner-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-hetzner-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-hetzner-upgrade-1.20-1.21
  • /test pull-kubeone-e2e-gce-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-gce-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-gce-upgrade-1.20-1.21
  • /test pull-kubeone-e2e-packet-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-packet-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-packet-upgrade-1.20-1.21
  • /test pull-kubeone-e2e-openstack-upgrade-1.18-1.19
  • /test pull-kubeone-e2e-openstack-upgrade-1.19-1.20
  • /test pull-kubeone-e2e-openstack-upgrade-1.20-1.21

Use /test all to run the following jobs:

  • pull-kubermatic-kubeone-validate-prow-yaml
  • pull-kubeone-verify-boilerplate
  • pull-kubeone-verify-codegen
  • pull-kubeone-license-validation
  • pull-kubeone-build
  • pull-kubeone-test
  • pull-kubeone-lint
  • pull-kubeone-e2e-aws-containerd-conformance-1.18
  • pull-kubeone-e2e-aws-flatcar-containerd-conformance-1.18
  • pull-kubeone-e2e-aws-conformance-1.19
  • pull-kubeone-e2e-aws-conformance-1.20
  • pull-kubeone-e2e-aws-conformance-1.21
  • pull-kubeone-e2e-aws-upgrade-containerd-1.17-1.18
  • pull-kubeone-e2e-aws-upgrade-1.18-1.19
  • pull-kubeone-e2e-aws-upgrade-1.19-1.20
  • pull-kubeone-e2e-aws-upgrade-1.20-1.21

In response to this:

/test pull-kubeone-e2e-aws-conformance-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Jun 29, 2021

/test pull-kubeone-e2e-aws-conformance-1.19

@kron4eg kron4eg marked this pull request as ready for review June 29, 2021 13:00
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 29, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Jun 29, 2021

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Jun 29, 2021

/test pull-kubeone-e2e-aws-conformance-1.20

@kron4eg
Copy link
Member Author

kron4eg commented Jun 29, 2021

Webhook in CI throwing mysterious

2021/06/29 15:21:09 http: panic serving 10.244.0.0:32339: runtime error: invalid memory address or nil pointer dereference
goroutine 1023 [running]:
net/http.(*conn).serve.func1(0xc0002e5c20)
	net/http/server.go:1801 +0x147
panic(0x2ced6e0, 0x52e3290)
	runtime/panic.go:975 +0x3e9
net/http.(*timeoutHandler).ServeHTTP(0xc0006d7000, 0x38829c0, 0xc0001d50a0, 0xc0000f9900)
	net/http/server.go:3277 +0x988
net/http.serverHandler.ServeHTTP(0xc0005c8460, 0x38829c0, 0xc0001d50a0, 0xc0000f9900)
	net/http/server.go:2843 +0xa3
net/http.(*conn).serve(0xc0002e5c20, 0x388dc40, 0xc0005469c0)
	net/http/server.go:1925 +0x8ad
created by net/http.(*Server).Serve
	net/http/server.go:2969 +0x36c

# go version
go version go1.16.5 linux/amd64

@moadqassem
Copy link
Member

/test pull-kubeone-e2e-aws-conformance-1.19

@xmudrii
Copy link
Member

xmudrii commented Jun 29, 2021

/test pull-kubeone-e2e-aws-conformance-1.20

@kron4eg kron4eg changed the title Upgrade machine-controller to v1.32.0 Upgrade machine-controller to v1.32.1 Jun 30, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Jun 30, 2021

/test pull-kubeone-e2e-aws-upgrade-1.19-1.20

@kron4eg kron4eg marked this pull request as draft June 30, 2021 16:16
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@kron4eg kron4eg changed the title Upgrade machine-controller to v1.32.1 Upgrade machine-controller to v1.33.0 Jun 30, 2021
@kron4eg
Upgrade machine-controller to v1.33.0
2192321 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg marked this pull request as ready for review June 30, 2021 17:11
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jun 30, 2021 •
edited
Loading

@kron4eg: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubeone-e2e-aws-upgrade-1.17-1.18 8eaa056 link /test pull-kubeone-e2e-aws-upgrade-1.17-1.18
pull-kubeone-e2e-aws-conformance-1.18 8eaa056 link /test pull-kubeone-e2e-aws-conformance-1.18
pull-kubeone-e2e-aws-upgrade-containerd-1.17-1.18 8a11954 link /test pull-kubeone-e2e-aws-upgrade-containerd-1.17-1.18

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Jun 30, 2021

/retest

xmudrii
xmudrii approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
🎉

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fc9845b16ea87b868c0bd14b686b021dea87001

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 0109aaf into kubermatic:master Jun 30, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Jun 30, 2021
@kron4eg kron4eg deleted the mc-1.31.0 branch July 1, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@kron4eg @xmudrii @kubermatic-bot @kubermatic-triage-bot @moadqassem