Add support for CentOS #154
Conversation
kubermatic-bot
added
the
release-note
kubermatic-bot
added
the
size/L
|
/test pull-kubeone-e2e |
| @@ -0,0 +1,8 @@ | |||
| variable "cluster_name" { | |||
There was a problem hiding this comment.
Potentially we should add SSH stuff here so KubeOne can pick it up like for AWS and DO.
There was a problem hiding this comment.
IMHO SSH should default to using the ssh agent and the root user if no other config was supplied (I added the latter in this PR) and if that works for a provider it shouldn't configure anything
|
Left two tiny nits, otherwise looks good from my side |
|
/test pull-kubeone-e2e |
pkg/terraform/config.go
Outdated
| return err | ||
| // copy over common config | ||
| if err = c.updateCommonWorkerConfig(existingWorkerSet, workersetValue[0]); err != nil { | ||
| return fmt.Errorf("failed to update common config from tf.json: %v", err) |
There was a problem hiding this comment.
Can we not call it tf.json, but "Terraform output" or "Terraform" or "Terraform config"? I call my file terraform.json and would be confused by the wording :)
|
/test pull-kubeone-e2e |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 13e4d5bebfd068c67653dc9bd40acc9b6a436f92
|
|
/lgtm |
|
LGTM label has been added. Git tree hash: db135c866281f832b6b59a389ff055815cb998d0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Closes #101
Special notes for your reviewer:
Documentation:
Release note:
/assign @kron4eg @xrstf
/cc @mrIncompetent