Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Go build tags #1545

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Fix Go build tags #1545

merged 1 commit into from
Sep 28, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 28, 2021

What this PR does / why we need it:

We didn't fix Go build tags for all files when updating to Go 1.17.1, so this PR fixes the build tags for the remaining files.

Does this PR introduce a user-facing change?:

NONE

@xmudrii
Fix Go build tags
7074677 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2021
xrstf
xrstf approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7532e3067de42db6e9592a66d27cfac23c8512e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 637bf93 into master Sep 28, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Sep 28, 2021
@kubermatic-bot kubermatic-bot deleted the go-bulid-tags branch September 28, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @xrstf