Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AzureFile CSI driver #1575

Merged
merged 7 commits into from
Oct 12, 2021
Merged

Add support for AzureFile CSI driver #1575

merged 7 commits into from
Oct 12, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 12, 2021

What this PR does / why we need it:

  • Add AzureFile CSI driver addon
  • Automatically deploy AzureFile CSI driver addon if external cloud controller manager (.cloudProvider.external) is enabled
  • Add default StorageClass for AzureFile CSI driver to the default-storage-class embedded addon
  • Automatically create cloud-config Secret for all providers if external cloud controller manager (.cloudProvider.external) is enabled

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1570

Special notes for your reviewer:

This PR has been manually tested using the following addon:

---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: pvc-azurefile
spec:
  accessModes:
    - ReadWriteMany
  resources:
    requests:
      storage: 1Gi
  storageClassName: azurefile-csi
---
kind: Pod
apiVersion: v1
metadata:
  name: nginx-azurefile
spec:
  nodeSelector:
    "kubernetes.io/os": linux
  containers:
    - image: mcr.microsoft.com/oss/nginx/nginx:1.19.5
      name: nginx-azurefile
      command:
        - "/bin/bash"
        - "-c"
        - set -euo pipefail; while true; do echo $(date) >> /mnt/azurefile/outfile; sleep 1; done
      volumeMounts:
        - name: persistent-storage
          mountPath: "/mnt/azurefile"
  volumes:
    - name: persistent-storage
      persistentVolumeClaim:
        claimName: pvc-azurefile

The azurefile-csi StorageClass can be created by deploying default-storage-class embedded addon.

Does this PR introduce a user-facing change?:

* Add AzureFile CSI driver addon
* Automatically deploy AzureFile CSI driver addon if external cloud controller manager (.cloudProvider.external) is enabled
* Add default StorageClass for AzureFile CSI driver to the default-storage-class embedded addon
* Automatically create cloud-config Secret for all providers if external cloud controller manager (.cloudProvider.external) is enabled

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg October 12, 2021 11:49
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 12, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2021
@xmudrii xmudrii changed the title Azurefile csi Add support for AzureFile CSI driver Oct 12, 2021
@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 12, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 44a59b3695670c0893ec4980ea4e988044167e71

@kubermatic-bot kubermatic-bot merged commit 68814c1 into master Oct 12, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Oct 12, 2021
@kubermatic-bot kubermatic-bot deleted the azurefile-csi branch October 12, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an addon for AzureFile CSI driver
3 participants