Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AzureDisk CSI driver #1577

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Add support for AzureDisk CSI driver #1577

merged 5 commits into from
Oct 13, 2021

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 13, 2021

What this PR does / why we need it:

  • Add AzureDisk CSI driver addon
  • Automatically deploy AzureDisk CSI driver addon if external cloud controller manager (.cloudProvider.external) is enabled
  • Add default StorageClass for AzureDisk CSI driver to the default-storage-class embedded addon

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1571
Fixes #1566

Special notes for your reviewer:

This PR has been manually tested using the following manifest:

---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: pvc-azuredisk
spec:
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 1Gi
  storageClassName: azuredisk-csi
---
kind: Pod
apiVersion: v1
metadata:
  name: nginx-azuredisk
spec:
  nodeSelector:
    "kubernetes.io/os": linux
  containers:
    - image: mcr.microsoft.com/oss/nginx/nginx:1.19.5
      name: nginx-azuredisk
      command:
        - "/bin/bash"
        - "-c"
        - set -euo pipefail; while true; do echo $(date) >> /mnt/azuredisk/outfile; sleep 1; done
      volumeMounts:
        - name: persistent-storage
          mountPath: "/mnt/azuredisk"
  volumes:
    - name: persistent-storage
      persistentVolumeClaim:
        claimName: pvc-azuredisk

Does this PR introduce a user-facing change?:

* Add AzureDisk CSI driver addon
* Automatically deploy AzureDisk CSI driver addon if external cloud controller manager (.cloudProvider.external) is enabled
* Add default StorageClass for AzureDisk CSI driver to the default-storage-class embedded addon

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg October 13, 2021 11:28
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 13, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 13, 2021
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0927c34812013d80afea6e76088b762f15c9b6b5

@xmudrii
Copy link
Member Author

xmudrii commented Oct 13, 2021

/retest

@kubermatic-bot kubermatic-bot merged commit 7a2b8d6 into master Oct 13, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Oct 13, 2021
@kubermatic-bot kubermatic-bot deleted the azuredisk-csi branch October 13, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an addon for AzureDisk CSI driver Add CSI driver addons for Azure
3 participants