-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CSI driver for AWS EBS #1597
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Skipping CI for Draft Pull Request. |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/assign @xmudrii I don't understand the failing test case tbh. It seems to be related to YAML processing, which this PR doesn't touch as far as I can say. |
/retest |
@embik this is a flake fail, it's based on the iteration over the map ordering and of course in Go this is randomized so sometimes we get this error. nothing to worry about. |
/assign |
That's not all. The docs state that we should also enable a bunch of feature gates on Kubelet and API server. Please take care of those feature gates as well. Regarding the CSI snapshotter, we deploy it for some other providers, so I think it makes sense to do it for AWS too. Take a look at Azure or vSphere CSI addons as an example.
I think this is fine. As a side note, the problem with hostnames for the worker nodes will be resolved by kubermatic/machine-controller#1087. |
@xmudrii the feature gates listed there should be all enabled by default in the Kubernetes versions we support. I assume the documentation lists them for completeness' sake or hasn't been updated: https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
So I think we don't need to change anything about the feature flags. |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
LGTM label has been added. Git tree hash: 9e103a1a4bffeae279076bf08d61e0cd50584288
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds the CSI driver for AWS EBS volumes to kubeone, offering an out-of-tree alternative to the built-in driver.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1565
Special notes for your reviewer:
Does this PR introduce a user-facing change?: