Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.3] Enable ip_tables modules and disable nm-cloud-setup for rhel on aws #1616

Merged
merged 8 commits into from
Nov 10, 2021
Merged

[release/v1.3] Enable ip_tables modules and disable nm-cloud-setup for rhel on aws #1616

merged 8 commits into from
Nov 10, 2021

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1607

/assign xmudrii

Enable ip_tables related kernel modules and disable nm-cloud-setup tool on aws for rhel machines

@moadqassem
enable ip_tables modules and disable nm-cloud-setup for rhel on aws
871671e 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
update fixtures
b16d0d1 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
addressing PR review
88871c4 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
update fixtures
5c0e880 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
running disable nm-cloud-setup tool on all nodes
00c91c8 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
move ip_tables loading to run on each boot
1721b7c 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
update test fixtures
3675e6d 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@moadqassem
addressing PR reviews
8b4e73e 
Signed-off-by: Moath Qasim <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Nov 10, 2021
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2021
@kubermatic-bot kubermatic-bot mentioned this pull request Nov 10, 2021
Merged
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 10, 2021
xmudrii
xmudrii approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: a80ad0a29f9fecc73b3d6832013424f47451ff70

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kubermatic-bot, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@kubermatic-bot kubermatic-bot merged commit 0ee34de into kubermatic:release/v1.3 Nov 10, 2021
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1607-to-release/v1.3 branch October 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@kubermatic-bot @xmudrii @moadqassem