Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Fix CSR approving issue for existing nodes with already approved and GCed CSRs #1897

Merged
merged 2 commits into from
Mar 17, 2022
Merged

[release/v1.4] Fix CSR approving issue for existing nodes with already approved and GCed CSRs #1897

merged 2 commits into from
Mar 17, 2022

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1894

/assign kron4eg

Fix CSR approving issue for existing nodes with already approved and GCed CSRs

@kron4eg
Fix CSR approving issue
297e38f 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix review feedback
4fdab60 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Mar 17, 2022
Merged
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Mar 17, 2022
@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 17, 2022
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2022
kron4eg
kron4eg approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 0f0f9719d4168b3b5109d7ea8d51552c32a14ac0

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, kubermatic-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@kron4eg
Copy link
Member

kron4eg commented Mar 17, 2022

/kind bug

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 17, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit f9c655f into kubermatic:release/v1.4 Mar 17, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1894-to-release/v1.4 branch October 4, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kubermatic-bot @kron4eg @kubermatic-triage-bot