-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/v1.4] Add (re-)rendering container runtime config to flatcar upgrades #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
kind/bug
Categorizes issue or PR as related to a bug.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
dco-signoff: yes
Denotes that all commits in the pull request have the valid DCO signoff message.
labels
Apr 1, 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Apr 1, 2022
xmudrii
changed the title
Flatcar cri config
Add (re-)rendering container runtime config to flatcar upgrades
Apr 1, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
force-pushed
the
flatcar-cri-config
branch
from
April 1, 2022 15:17
bad99e0
to
a27fa83
Compare
/lgtm |
LGTM label has been added. Git tree hash: 8dd1b0b59b785f685ff21d68a71d9d460a98e3f1
|
xmudrii
changed the title
Add (re-)rendering container runtime config to flatcar upgrades
[release/v1.4] Add (re-)rendering container runtime config to flatcar upgrades
Apr 1, 2022
/retest |
2 similar comments
/retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
dco-signoff: yes
Denotes that all commits in the pull request have the valid DCO signoff message.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
Indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR is a manual cherry-pick of #1910 to the
release/v1.4
branch. The PR has been tested and it works as expected.Does this PR introduce a user-facing change?: