Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] Add (re-)rendering container runtime config to flatcar upgrades #1918

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 1, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is a manual cherry-pick of #1910 to the release/v1.4 branch. The PR has been tested and it works as expected.

Does this PR introduce a user-facing change?:

Regenerate container runtime configurations based on kubeone.yaml during control-plane upgrades on Flatcar Linux nodes, not only on the initial installation.

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 1, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2022
@xmudrii xmudrii changed the title Flatcar cri config Add (re-)rendering container runtime config to flatcar upgrades Apr 1, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xrstf
Copy link
Contributor

xrstf commented Apr 1, 2022

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8dd1b0b59b785f685ff21d68a71d9d460a98e3f1

@xmudrii xmudrii changed the title Add (re-)rendering container runtime config to flatcar upgrades [release/v1.4] Add (re-)rendering container runtime config to flatcar upgrades Apr 1, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Apr 1, 2022

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Apr 1, 2022

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Apr 1, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 570f7fb into release/v1.4 Apr 1, 2022
@kubermatic-bot kubermatic-bot deleted the flatcar-cri-config branch April 1, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants