Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Use config to pre-pull images #2028

Merged
merged 2 commits into from
May 10, 2022
Merged

[release/v1.4] Use config to pre-pull images #2028

merged 2 commits into from
May 10, 2022

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 10, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:
backport of #2026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[release/v1.4] Use config to pre-pull images

@kron4eg
[release/v1.4] Use config to pre-pull images (kubermatic#2026)
a2a48cd 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2022
xmudrii
xmudrii approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26402933a8e684b1b5d2b8a66ad29096596f11c6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@xmudrii
Copy link
Member

xmudrii commented May 10, 2022

/retest

@kron4eg
Fix pre-pull images yet again
f688810 
Because we tried to pre-pull images before upgrading kubeadm it failed
during the upgrade process for kubernetes v1.21 (prior v1beta3 kubeadm).

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8422345d0200eb0e558ae50c7ab21f2fd9bb4f2d

@kubermatic-bot kubermatic-bot merged commit dd1c4b8 into kubermatic:release/v1.4 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii