Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure CCM, AzureDisk CSI and AzureFile CSI #2058

Merged
merged 3 commits into from
May 27, 2022
Merged

Update Azure CCM, AzureDisk CSI and AzureFile CSI #2058

merged 3 commits into from
May 27, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 26, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Update Azure CCM to v1.24.0, v1.23.11, v1.1.14 (for Kubernetes 1.22), v1.0.18 (for Kubernetes 1.21), v0.7.21 (for Kubernetes 1.20)
  • Update AzureDisk CSI driver to v1.18.0
  • Update AzureFile CSI driver to v1.18.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2011

Does this PR introduce a user-facing change?:

Update Azure CCM to v1.24.0, v1.23.11, v1.1.14 (for Kubernetes 1.22), v1.0.18 (for Kubernetes 1.21), v0.7.21 (for Kubernetes 1.20)
Update AzureDisk CSI driver to v1.18.0
Update AzureFile CSI driver to v1.18.0

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg May 26, 2022 11:40
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 26, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2022
@xmudrii xmudrii changed the title Azure updates Update Azure CCM, AzureDisk CSI and AzureFile CSI May 26, 2022
@xmudrii xmudrii mentioned this pull request May 26, 2022
Closed
20 tasks
@xmudrii
Update AzureDisk and AzureFile CSI drivers to v1.18.0
19c5b35 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update Azure CCM
85e1426 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Ensure addon compatibility with KubeOne 1.4
7962001 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii marked this pull request as ready for review May 27, 2022 10:49
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 27, 2022
kron4eg
kron4eg reviewed May 27, 2022
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

addons/ccm-azure/ccm-azure.yaml Show resolved Hide resolved
addons/ccm-azure/ccm-azure.yaml Show resolved Hide resolved
addons/csi-azuredisk/csi-azuredisk-node.yaml Show resolved Hide resolved
@kron4eg
Copy link
Member

kron4eg commented May 27, 2022

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed827601ceeb32c8bd772071333076426bf6430e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@xmudrii
Copy link
Member Author

xmudrii commented May 27, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit 80ebd55 into master May 27, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone May 27, 2022
@kubermatic-bot kubermatic-bot deleted the azure-updates branch May 27, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg left review comments

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg