Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenStack CCM and Cinder CSI #2061

Merged
merged 2 commits into from
May 30, 2022
Merged

Update OpenStack CCM and Cinder CSI #2061

merged 2 commits into from
May 30, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 27, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add support for OpenStack CCM v1.24.0 (for Kubernetes 1.24 clusters)
  • Add support for OpenStack Cinder CSI driver v1.24.0 (for Kubernetes 1.24 clusters)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2011

Does this PR introduce a user-facing change?:

Add support for OpenStack CCM v1.24.0 (for Kubernetes 1.24 clusters)
Add support for OpenStack Cinder CSI driver v1.24.0 (for Kubernetes 1.24 clusters)

/assign @kron4eg

@xmudrii
Update OpenStack CCM for Kubernetes v1.24 and v1.23
246e931 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg May 27, 2022 11:13
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels May 27, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 27, 2022
@xmudrii xmudrii mentioned this pull request May 27, 2022
Closed
20 tasks
@xmudrii
Update OpenStack Cinder CSI
3b0163f 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii marked this pull request as ready for review May 30, 2022 15:57
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2022
kron4eg
kron4eg approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aef78c8ca24ea45429a2e2b3e6a1c30a134e1269

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2022
@mate4st
Copy link
Contributor

mate4st commented May 30, 2022

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2022
@mate4st
Copy link
Contributor

mate4st commented May 30, 2022

I think some parts for the snapshotter are missing. xref: kubermatic/kubermatic#9893

@xmudrii
Copy link
Member Author

xmudrii commented May 30, 2022

@weirdmachine They are missing, but this is going to be handled in a different PR since other providers are (potentially) affected as well. See #2051 for more details.

@xmudrii
Copy link
Member Author

xmudrii commented May 30, 2022

/test all

@mate4st
Copy link
Contributor

mate4st commented May 30, 2022

/unhold

@xmudrii sure you are already aware, my bad :)

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2022
@kubermatic-bot kubermatic-bot merged commit 36eb7f6 into master May 30, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone May 30, 2022
@kubermatic-bot kubermatic-bot deleted the openstack-updates branch May 30, 2022 17:09
@embik embik mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kubermatic-bot @mate4st @kron4eg