Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Azure osDiskSKU and dataDiskSKU example values #2084

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Update Azure osDiskSKU and dataDiskSKU example values #2084

merged 1 commit into from
Jun 2, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 2, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update Azure osDiskSKU and dataDiskSKU example values

Does this PR introduce a user-facing change?:

NONE

/assign @embik @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2022
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 2, 2022
@xmudrii xmudrii mentioned this pull request Jun 2, 2022
Merged
@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2022
@xmudrii xmudrii mentioned this pull request Jun 2, 2022
Merged
@xmudrii xmudrii marked this pull request as draft June 2, 2022 08:40
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2022
@xmudrii
Update Azure osDiskSKU and dataDiskSKU example values
58d77c4 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii changed the title Update machine-controller Go dependency to v1.51.0 and Azure osDiskSKU and dataDiskSKU example values Update Azure osDiskSKU and dataDiskSKU example values Jun 2, 2022
@kubermatic-bot kubermatic-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2022
@xmudrii xmudrii marked this pull request as ready for review June 2, 2022 08:45
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7c78c9dc5cbefd9eee9052f46a35c5cdefa6a3cd

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@kubermatic-bot kubermatic-bot merged commit 3722397 into master Jun 2, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone Jun 2, 2022
@kubermatic-bot kubermatic-bot deleted the updates-2 branch June 2, 2022 08:54
@xmudrii xmudrii mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@embik embik

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kubermatic-bot @embik @ahmedwaleedmalik