Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] Disable node IPAM in Azure CCM #2107

Merged

Conversation

rastislavs
Copy link
Contributor

What type of PR is this?

This is a manual cherry-pick of #2106

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Disable node IPAM in Azure CCM

Signed-off-by: Rastislav Szabo <rastislav@kubermatic.com>
@rastislavs rastislavs requested a review from kron4eg June 20, 2022 21:22
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/kind bug

@kubermatic-bot kubermatic-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 20, 2022
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b69033998017d59323e8f97cfb8b19bd8be842a8

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@xmudrii
Copy link
Member

xmudrii commented Jun 20, 2022

/retest

@xmudrii
Copy link
Member

xmudrii commented Jun 20, 2022

/test all

@xmudrii xmudrii closed this Jun 20, 2022
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 20, 2022
@xmudrii xmudrii reopened this Jun 20, 2022
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2022
@kubermatic-bot kubermatic-bot merged commit 00c4bce into kubermatic:release/v1.4 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants