Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Equinix Metal CCM to v3.4.3 #2174

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Update Equinix Metal CCM to v3.4.3 #2174

merged 1 commit into from
Jul 23, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 22, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update Equinix Metal CCM to v3.4.3.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2011

Does this PR introduce a user-facing change?:

Update Equinix Metal CCM to v3.4.3

@xmudrii
Update Equinix Metal CCM to v3.4.3
75e0bb2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 22, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@xmudrii xmudrii mentioned this pull request Jul 22, 2022
Closed
20 tasks
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Jul 22, 2022

/test pull-kubeone-e2e-equinixmetal-default-install-containerd-v1.21.14
/test pull-kubeone-e2e-equinixmetal-default-install-containerd-v1.22.11
/test pull-kubeone-e2e-equinixmetal-default-install-containerd-v1.23.8
/test pull-kubeone-e2e-equinixmetal-default-install-containerd-v1.24.2

@xmudrii
Copy link
Member Author

xmudrii commented Jul 22, 2022

/test pull-kubeone-e2e-equinixmetal-default-install-containerd-v1.22.11

@xmudrii xmudrii marked this pull request as ready for review July 23, 2022 12:21
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 23, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Jul 23, 2022

I already manually tested this PR and it seems to work as expected. This includes running this PR on a cluster created with KubeOne v1.4.5.

@xmudrii
Copy link
Member Author

xmudrii commented Jul 23, 2022

/hold
to let #2183 go in first.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2022
xrstf
xrstf approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 428563a8f657bb383cfdd6af9ab8d4774ca62f5e

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Jul 23, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2022
@kubermatic-bot kubermatic-bot merged commit 6aff98f into master Jul 23, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone Jul 23, 2022
@kubermatic-bot kubermatic-bot deleted the equinix-update branch July 23, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf xrstf approved these changes

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @xrstf