PodSecurityPolicy switch #218
Conversation
kubermatic-bot
added
release-note
* new config option features.enabled_psp * regenerate kubeadm config every upgrade
|
/hold |
kubermatic-bot
added
the
do-not-merge/hold
|
/test pull-kubeone-e2e |
kubermatic-bot
added
the
do-not-merge/work-in-progress
kubermatic-bot
added
size/XL
kubermatic-bot
removed
the
do-not-merge/work-in-progress
|
/hold cancel |
kubermatic-bot
removed
the
do-not-merge/hold
| ) | ||
|
|
||
| var ( | ||
| defaultAdmissionPlugins = []string{ |
There was a problem hiding this comment.
Are those admission plugins same for all Kubernetes versions?
There was a problem hiding this comment.
for what we currently support — yes, maybe that will be changed in the future
| } | ||
| } | ||
|
|
||
| func boolPtr(b bool) *bool { |
There was a problem hiding this comment.
A follow up: create a package for such functions or check does client-go ships something.
There was a problem hiding this comment.
I tried to find such thing in k8s.io libs, but seems like everyone agree that "small copy is better then small dependency" and no one exports it.
pkg/features/activate.go
Outdated
| } | ||
|
|
||
| // KubeadmActivate features in cluster config | ||
| func KubeadmActivate(featuresCfg config.Features, clusterConfig *kubeadmv1beta1.ClusterConfiguration) { |
There was a problem hiding this comment.
At the first thought I was unsure what this function does. A better function name or improved comment would be appreciated.
There was a problem hiding this comment.
I'm all open for better name suggestions
|
/test pull-kubeone-lint |
|
/approve |
|
LGTM label has been added. Git tree hash: 7e171644b3fb1852cd4a988ffba610194157b52a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Allows enable/disable PodSecurityPolicy admission plugin
Fixes #195