Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.43] Update machine-controller to v1.43.4 #2193

Merged
merged 1 commit into from
Jul 26, 2022
Merged

[release/v1.43] Update machine-controller to v1.43.4 #2193

merged 1 commit into from
Jul 26, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 26, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update machine-controller to v1.43.4.

This machine-controller release fixes an issue with finding Node objects by ProviderID.

Does this PR introduce a user-facing change?:

Update machine-controller to v1.43.4. This machine-controller release fixes an issue with finding Node objects by ProviderID

/assign @kron4eg

@xmudrii
Update machine-controller to v1.43.4
005b20d 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg July 26, 2022 13:29
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2022
@kron4eg
Copy link
Member

kron4eg commented Jul 26, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ffb61f05ec3c7a71066c66128c1ec9098caffa8f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@kubermatic-bot kubermatic-bot merged commit 1f9f9b2 into release/v1.4 Jul 26, 2022
@kubermatic-bot kubermatic-bot deleted the mc-1.43.4 branch July 26, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot