Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Add external Cloud Provider and CSI migration flags to OSM #2203

Merged
merged 1 commit into from
Jul 28, 2022
Merged

[release/v1.4] Add external Cloud Provider and CSI migration flags to OSM #2203

merged 1 commit into from
Jul 28, 2022

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #2202

/assign ahmedwaleedmalik

Properly propagate external cloud provider and CSI migration options to OSM

@xmudrii
Add external Cloud Provider and CSI migration flags to OSM
cab2ce4 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 28, 2022
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2022
xmudrii
xmudrii approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@kubermatic-bot kubermatic-bot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 28, 2022
@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 28, 2022
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: b11070c1148013e6c86b4ec01fdf36f93a40231a

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@xmudrii
Copy link
Member

xmudrii commented Jul 28, 2022

/test pull-kubeone-e2e-aws-conformance-1.23

@kubermatic-bot kubermatic-bot merged commit 970c4ef into kubermatic:release/v1.4 Jul 28, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-2202-to-release/v1.4 branch October 4, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubermatic-bot @xmudrii @ahmedwaleedmalik