Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Enable nf_conntrack module by default #2283

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[release/v1.4] Enable nf_conntrack module by default #2283

merged 2 commits into from
Aug 16, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 16, 2022

What this PR does / why we need it:

This PR is a manual cherry-pick of #2282.

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Enable `nf_conntrack` (`nf_conntrack_ipv4`) module by default on all operating systems. This fixes an issue with pods unable to reach services running on a host on operating systems that are using the NFT backend.

Documentation:

NONE

@xmudrii
Enable nf_conntrack module by default
fdaf1f1 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update fixtures
001785c 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 16, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2022

/hold

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4696f2f31fd95aa22eb8df933c8c5dcb7f5757e5

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@kubermatic-bot kubermatic-bot merged commit a21d71e into release/v1.4 Aug 16, 2022
@kubermatic-bot kubermatic-bot deleted the modprobe-nf_conntrack-1.4 branch August 16, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik