Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaulting for provisioning utility in AWS configs #2285

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Remove defaulting for provisioning utility in AWS configs #2285

merged 3 commits into from
Aug 16, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 16, 2022 •
edited
Loading

What this PR does / why we need it:

Remove defaulting for provisioning utility in example Terraform configs for AWS. The provisioning utility is defaulted by machine-controller.

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] Remove defaulting for Flatcar provisioning utility in example Terraform configs for AWS (defaulted to Ignition by machine-controller). If you have Flatcar-based MachineDeployments that use the `cloud-init` provisioning utility, you must change the provisioning utility to `ignition` (or leave it empty) for Operating System Manager (OSM) to work properly

Documentation:

NONE

@xmudrii
Remove defaulting for provisioning utility in AWS configs
b503e2b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Unset provisioning_utility in the E2E tests
c2cd424 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2022

/test pull-kubeone-e2e-aws-flatcar-install-containerd-v1.24.3

@xmudrii
Update Terraform docs
83b2288 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Aug 16, 2022

/test pull-kubeone-e2e-aws-flatcar-install-containerd-v1.24.3

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7bfbc7c5ad60cd576992e52f952eb400b73b41b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 16, 2022
@xmudrii xmudrii mentioned this pull request Aug 16, 2022
Merged
@xmudrii xmudrii added this to the KubeOne 1.5 milestone Aug 16, 2022
@kubermatic-bot kubermatic-bot merged commit 881721d into master Aug 16, 2022
@kubermatic-bot kubermatic-bot deleted the aws-provisioning-utility branch August 16, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik