Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.5] Refactor validation for csiConfig #2447

Merged
merged 2 commits into from
Nov 7, 2022
Merged

[release/v1.5] Refactor validation for csiConfig #2447

merged 2 commits into from
Nov 7, 2022

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #2430

/assign xmudrii

- `.cloudProvider.csiConfig` is now a mandatory field for vSphere clusters using the external cloud provider (`.cloudProvider.external: true`)
- `.cloudProvider.csiConfig` can be specified even if the in-tree provider is used, but the provided CSIConfig is ignored in such cases (a warning about this is printed)

@xmudrii
Refactor validation for csiConfig
7610b7a 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add a warning if CSIConfig is used with in-tree provider
ec64cb7 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot mentioned this pull request Nov 7, 2022
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2022
xmudrii
xmudrii approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/kind api-change

@kubermatic-bot kubermatic-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. labels Nov 7, 2022
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: 9cb0abe02760fa88bc0e06ab9a94fb1221dd01ef

@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Nov 7, 2022
@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@kubermatic-bot kubermatic-bot merged commit ce0c2ab into kubermatic:release/v1.5 Nov 7, 2022
@kubermatic-bot kubermatic-bot deleted the cherry-pick-2430-to-release/v1.5 branch October 4, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubermatic-bot @xmudrii