Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.5] Update Golang to 1.19.3 #2462

Merged
merged 1 commit into from
Nov 8, 2022
Merged

[release/v1.5] Update Golang to 1.19.3 #2462

merged 1 commit into from
Nov 8, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 8, 2022

What this PR does / why we need it:

This PR updates Go to 1.19.3 on the release/v1.5 branch. It includes:

  • Updating all the jobs that use the kubeone-e2e image to v0.1.26
  • Updating all the jobs that use quay.io/kubermatic/build to go-1.19-node-18-kind-0.17-4
  • Updating all the jobs that use the golang image to 1.19.3
  • Updating Dockerfile to 1.19.3

What type of PR is this?

/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeOne is now built using Go 1.19.3

Documentation:

NONE

@xmudrii
Update Golang to 1.19.3
48e89e5 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 8, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 👍

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 046386cf399977a06791d00a59ea0c5064f6fc4e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@kubermatic-bot kubermatic-bot merged commit f7730ec into release/v1.5 Nov 8, 2022
@kubermatic-bot kubermatic-bot deleted the go-1193-1.5 branch November 8, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik