Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Update Golang to v1.18.8 and use quay.io/kubermatic/kubeone-e2e image #2465

Merged
merged 2 commits into from
Nov 8, 2022
Merged

[release/v1.4] Update Golang to v1.18.8 and use quay.io/kubermatic/kubeone-e2e image #2465

merged 2 commits into from
Nov 8, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 8, 2022

What this PR does / why we need it:

What type of PR is this?

/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

- KubeOne is now built using Go 1.18.8
- The `kubeone-e2e` image is moved from Docker Hub to Quay (`quay.io/kubermatic/kubeone-e2e`)

Documentation:

NONE

@xmudrii
Update Golang to v1.18.8 and use quay.io/kubermatic/kubeone-e2e image
059351f 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2022
xmudrii
xmudrii commented Nov 8, 2022
View reviewed changes
hack/images/kubeone-e2e/release.sh
@@ -16,7 +16,7 @@

set -euox pipefail

TAG=v0.1.20
TAG=v0.1.27-go-1.18
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image has been pushed manually. We don't have automation to push from the release branches.

xmudrii
xmudrii commented Nov 8, 2022
View reviewed changes
.prow.yaml
@@ -24,7 +24,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: golang:1.17.5
- image: golang:1.18.8
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are actually building KubeOne 1.4 with Go 1.18 for quite a while (I'm not sure when we introduced this change exactly). That being said, this is not upgrading the Go version from 1.17 to 1.18, that already happened before.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 502e5a69c3fbad064b71b0ae01140249a513c3f1

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 8, 2022

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Nov 8, 2022

/retest

@xmudrii
Skip validating kubetest binary
4095366 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 8, 2022

/hold
I'm testing if we can drop kubetest as a requirement for the old testing framework.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 8, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@moadqassem
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc844fda6f986e5e9efff101c271ce5022b643bd

@kubermatic-bot kubermatic-bot merged commit 7a828ca into release/v1.4 Nov 8, 2022
@kubermatic-bot kubermatic-bot deleted the go-1188-1.4 branch November 8, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@kron4eg kron4eg

@moadqassem moadqassem

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xmudrii @kubermatic-bot @kron4eg @moadqassem @ahmedwaleedmalik